Attention is currently required from: jolly, pespin. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/38513?usp=email )
Change subject: Release BSS connection when CC transaction fails ...................................................................... Patch Set 1: (2 comments) File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/38513/comment/838efbfb_8321fa0f?usp=email : PS1, Line 2640: return -EINVAL; > shall we do something here? For the record, we found out that this check is no-op because `gsm48_hdr_msg_type()` returns `hdr->msg_type & 0x3f` for `GSM48_PDISC_CC`. It's always false because `msg_type` has bits 6-7 zeroed. See: https://gerrit.osmocom.org/c/osmo-msc/+/38579. https://gerrit.osmocom.org/c/osmo-msc/+/38513/comment/3f2652bb_c62836dd?usp=email : PS1, Line 2645: return -EINVAL; > shall we do something here? We concluded that `MSC_A_USE_CM_SERVICE_CC` should be put here too. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38513?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Icb893d5c1ce4c77a29259ce66189576dcaa5a44a Gerrit-Change-Number: 38513 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Wed, 30 Oct 2024 16:06:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]>
