Patch Set 1: (1 comment)
https://gerrit.osmocom.org/#/c/6097/1/include/osmo-bts/gsm_data.h File include/osmo-bts/gsm_data.h: Line 97: const struct bts_cm *cm; /* Table with supp. ch rate/mode combinations */ if this is alway an array that needs to be as large as MAX_PCHAN_T, then why not simply have it as a static array here? Allowing it to be dynamically allocated just makes it harder to use, as somebody could allocate a too small array, and the generic code has no way of knowing the size of that array. -- To view, visit https://gerrit.osmocom.org/6097 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9b222b7ab19ece90591718bc562b3a8c5e02023 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-HasComments: Yes
