Attention is currently required from: pespin.

fixeria has posted comments on this change by fixeria. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671?usp=email )

Change subject: hlr: refactor f_SS_expect()
......................................................................


Patch Set 1:

(3 comments)

File hlr/HLR_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671/comment/cee635c9_d4c524ba?usp=email
 :
PS1, Line 741:  /* case a) SS Info is can be any value or not present */
> "is can be" <-wrong
Acknowledged


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671/comment/202c0bc2_d18e6696?usp=email
 :
PS1, Line 746:  /* case b) SS Info is shall *not* be present */
> "is shall" all this is gramaptically incorrect, remove the "is" please.
Acknowledged


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671/comment/ae0ddf4e_30e95695?usp=email
 :
PS1, Line 755:  /* case c) SS Info is shall be present */
> same
Acknowledged



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I162a79e3c7ff9dafb031e3da8a78af313534cac7
Gerrit-Change-Number: 38671
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Wed, 06 Nov 2024 16:08:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to