Attention is currently required from: pespin.

laforge has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38645?usp=email )

Change subject: sigtran: Make osmo_ss7_asp struct private
......................................................................


Patch Set 3:

(1 comment)

File src/ipa.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/38645/comment/687fbc7b_0668fb4a?usp=email
 :
PS3, Line 50: #i
I think naming-wise it's sad that we no longer have the _internal.h for 
internal (non-public) header files.  That was originally the point of having 
{xua,ss7}_internal.h.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38645?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I5839b4dd04468af20d1836386dcc722e7a83ac5f
Gerrit-Change-Number: 38645
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Thu, 07 Nov 2024 04:17:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to