Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38659?usp=email )
Change subject: pySim-shell: add utility to measure execution time ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I think this new command with its argparse needs to be added to the user manual? Also, what about an alternative approach of always measuring the time of execution of a single command and printing it (depending on a settable variable like "set timestamping true") together with the results of the command? This way we wouldn't need to maintain an explicit counter that can be set and updated/reset. I understand there are specific use cases for it, so maybe both options make sense by themselves.... A third idea would be to introduce a "time" command like on the shell. So you could execute something like "time select ADF.USIM" and it would perform whatever command you specify as well as printing the execution time once completed. I guess this can be difficult to implement from a command parser / tab completion point of view, but still wanted to share the idea. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38659?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I356ea44e08efe93fe927dbc20564bf850278b546 Gerrit-Change-Number: 38659 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Thu, 07 Nov 2024 04:39:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
