Attention is currently required from: pespin.

fixeria has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38676?usp=email )

Change subject: hnbgw: Add test TC_ps_rab_assignment_concurrent
......................................................................


Patch Set 1: Code-Review+2

(2 comments)

File hnbgw/HNBGW_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38676/comment/9d9c9f56_4c79a061?usp=email
 :
PS1, Line 1523: vc_conn_list := vc_conn_list & { vc_conn };
BTW, you can just do `vc_conn_list[i] := vc_conn;` -- this works fine.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38676/comment/ec60fc96_0e7060c5?usp=email
 :
PS1, Line 1527: vc_conn_list[i].done;
Maybe add `f_ConnHdlrList_all_done()` like we did in S1GW_Tests?



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38676?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I053950373cec93ed8dbdfd6b8a71ffe31de3806f
Gerrit-Change-Number: 38676
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Thu, 07 Nov 2024 12:57:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to