Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38640?usp=email )
Change subject: sigtran: Make osmo_ss7_user APIs private ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: > I don't like this, as it constrains other (non-SCCP) users from being > implemented. […] Well my point is that when somebody wants to use that outside the library, then it's the time to make public APIs to be able to do so, but never accessing the struct directly. I can add public APIs now in this patch if that is a must now. I need then to figure out how is this supposed to be used from and outside-lib user. File src/ss7_user.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/38640/comment/e9c2eddb_7d3d5128?usp=email : PS2, Line 33: int osmo_ss7_user_mtp_xfer_req(struct osmo_ss7_instance *inst, I need to check this one, this may need to stay in the public header or change thre prefix here. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38640?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I59d8f70aa81ba396159af40ffd7e8cc6c27cb864 Gerrit-Change-Number: 38640 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Thu, 07 Nov 2024 12:50:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]>
