Attention is currently required from: osmith.

pespin has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38674?usp=email )

Change subject: hnbgw: with-pfcp: Support running ConnHdlr concurrently
......................................................................


Patch Set 1:

(1 comment)

File hnbgw/HNBGW_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38674/comment/c34b4960_3ef8752a?usp=email
 :
PS1, Line 595:                            upf_f_seid := 1000 + imsi_suffix);
> does this belong into the previous patch?
It could, depending on how you split stuff. In my submission the first patch 
simply allows parametrizing it, as a preparation, while this patch actually 
does the changes required to be able to run them concurrently.

I don't think one is better than the other so I'm fine with this one.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38674?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie19ee0bd1b811e9381e3c245a4b1208de8afcbce
Gerrit-Change-Number: 38674
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Comment-Date: Thu, 07 Nov 2024 12:44:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <[email protected]>

Reply via email to