Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38663?usp=email )
Change subject: sigtran: Split osmo_ss7_instance allocation into its own function ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-sigtran/+/38663/comment/0ae20b3d_2f43277f?usp=email : PS2, Line 7: Split > Why? Are you planning to use it somewhere else? It just follows the usual object structure where you have an _alloc() and a _free()/_destroy() function. Makes it a lot easier to find out stuff. Also, it allows separating the lookup from the allocation, which really has nothing to do. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38663?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I38f9f19bb43d29999c4a7ba1a537403d1d58e880 Gerrit-Change-Number: 38663 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Thu, 07 Nov 2024 19:48:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]>
