Attention is currently required from: pespin.

fixeria has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/38650?usp=email )

Change subject: Use new libosmo-sigtran API osmo_ss7_instance_get_id()
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/osmo-bsc/+/38650/comment/3c6eb05f_1d6354ed?usp=email
 :
PS1, Line 9: Change-IdChange-Id
`Change-Id` twice.

BTW, is it really necessary to say `Change-Id`? Doesn't the `I` at the 
beginning imply that?



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38650?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic0a468de0e8852ddd1ebd99f25a6400475af9a1f
Gerrit-Change-Number: 38650
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Fri, 08 Nov 2024 10:50:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to