Attention is currently required from: JPM, dexter, laforge. fixeria has posted comments on this change by JPM. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email )
Change subject: Fixing 3-digit MNC PlmnAdapter encoding and decoding. Adding test_plmn_adapter. ...................................................................... Patch Set 3: (2 comments) Patchset: PS1: > I meant this should be mentioned in the code, in a comment. Done File src/osmocom/construct.py: https://gerrit.osmocom.org/c/python/pyosmocom/+/38687/comment/385bf24e_345e4e60?usp=email : PS1, Line 265: """convert a bytes(3) type to BCD string like 262-02 or 262-002.""" > Let's add spec. reference here? 3GPP TS 24. […] Done -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I3811b227d629bd4e051a480c9622967e31f8a376 Gerrit-Change-Number: 38687 Gerrit-PatchSet: 3 Gerrit-Owner: JPM <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: JPM <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Fri, 08 Nov 2024 16:24:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: JPM <[email protected]> Comment-In-Reply-To: fixeria <[email protected]>
