pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38726?usp=email )
Change subject: bsc: Fix sporadic failure in .TC_ho_in_fail_ipa_crcx_timeout
......................................................................
bsc: Fix sporadic failure in .TC_ho_in_fail_ipa_crcx_timeout
The code path was not waiting to receive DLCX if parameter
ignore_mgw_mdcx was set to false. It should wait for DLCX in any case.
Since it didn't wait, te ConnHdlr would finish earlier than expected and
MGCP_Emulation would fail when forwarding the DLCX to ConnHdlr:
"""
MGCP_Emulation.ttcn:257 Dynamic test case error: Sending data on the connection
of port MGCP_CLIENT to 2023:MGCP failed. (Broken pipe)
"""
Change-Id: I322b070c369500979e3cc13814de1e4bf067726f
---
M bsc/BSC_Tests.ttcn
1 file changed, 9 insertions(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/26/38726/1
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 4d60ea8..83389a6 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -6456,15 +6456,17 @@
/* When we let MGCP MDCX run into a timeout, it's still in the
* queue and additionally after BSSAP HandoverFailure, two DLCX
* get sent (for AoIP, for SCCPlite one DLCX). */
- if (g_pars.ignore_mgw_mdcx) {
- if (g_pars.aoip) {
+ if (g_pars.aoip) {
+ if (g_pars.ignore_mgw_mdcx) {
MGCP.receive(tr_MDCX);
- MGCP.receive(tr_DLCX);
- MGCP.receive(tr_DLCX);
- } else {
-
MGCP_MULTI.receive(tr_MGCP_RecvFrom_any({command := tr_MDCX}));
-
MGCP_MULTI.receive(tr_MGCP_RecvFrom_any({command := tr_DLCX}));
}
+ MGCP.receive(tr_DLCX);
+ MGCP.receive(tr_DLCX);
+ } else {
+ if (g_pars.ignore_mgw_mdcx) {
+
MGCP_MULTI.receive(tr_MGCP_RecvFrom_any({command := tr_MDCX}));
+ }
+ MGCP_MULTI.receive(tr_MGCP_RecvFrom_any({command :=
tr_DLCX}));
}
return;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38726?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I322b070c369500979e3cc13814de1e4bf067726f
Gerrit-Change-Number: 38726
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
