Attention is currently required from: osmith.

pespin has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38719?usp=email )

Change subject: sigtran: Add API osmo_ss7_as_select_asp()
......................................................................


Patch Set 1:

(1 comment)

File src/osmo_ss7_as.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/38719/comment/abfa3ed9_ec250cb4?usp=email
 :
PS1, Line 272:                  break; /* Early return above: */
> maybe refactor to this instead, to get rid of cnt? […]
ACK good point.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38719?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I8b866b45ac4a24238c55171d25e11b9625e8f50c
Gerrit-Change-Number: 38719
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Comment-Date: Mon, 11 Nov 2024 15:07:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <[email protected]>

Reply via email to