Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/38733?usp=email )
Change subject: Make compatible with private sigtran structs ...................................................................... Patch Set 1: (1 comment) File src/osmo-msc/msc_main.c: https://gerrit.osmocom.org/c/osmo-msc/+/38733/comment/2a696bc6_0bcb9fed?usp=email : PS1, Line 814: osmo_ss7_instance_get_name(ss7)); can we store all these in local variables so that we don't need to ifdef in 2 different places? It's level NOTICE so it's fine doing it outside the log define. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38733?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: osmith/1.12.2 Gerrit-Change-Id: I6c7d5119174de8d37d1ebe2b47793f9b89cc903c Gerrit-Change-Number: 38733 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Comment-Date: Tue, 12 Nov 2024 16:00:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
