Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/38740?usp=email )
Change subject: trxcon/l1sched: fix FACCH/H regression in rx_tchh_fn() ...................................................................... Patch Set 1: (1 comment) File src/host/trxcon/src/sched_lchan_tchh.c: https://gerrit.osmocom.org/c/osmocom-bb/+/38740/comment/16a42d33_9df35e02?usp=email : PS1, Line 86: /* TDMA frame number of burst 'f' is used as the table index. */ so you are numbering the bursts a,b,c,d,e,f? Is that specified like that somewhere? otherwise I find it confusing tbh. Maybe add "(last)" here and "(first)" below? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/38740?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia4b737cf11d4d9ce9847cabb77189e9cbcbb8840 Gerrit-Change-Number: 38740 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-CC: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Tue, 12 Nov 2024 18:01:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
