Attention is currently required from: pespin.

osmith has posted comments on this change by osmith. ( 
https://gerrit.osmocom.org/c/osmo-hnbgw/+/38736?usp=email )

Change subject: Add osmo_ss7 APIs
......................................................................


Patch Set 2:

(1 comment)

File include/osmocom/hnbgw/hnbgw.h:

https://gerrit.osmocom.org/c/osmo-hnbgw/+/38736/comment/a5e48833_d65acf84?usp=email
 :
PS1, Line 339: #ifdef SIGTRAN_PRIVATE_STRUCTS
> Did you think about actually defining the APIs here as static inline instead? 
> […]
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38736?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: osmith/1.6.2
Gerrit-Change-Id: I9e53953bc56fc5920eefb0a39dbf1e0b9843e00e
Gerrit-Change-Number: 38736
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Wed, 13 Nov 2024 12:15:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to