fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38745?usp=email )
Change subject: epdg: fix a DTE in as_GSUP_rx_CL_REQ
......................................................................
epdg: fix a DTE in as_GSUP_rx_CL_REQ
Recent commit 51490419 uncovered a problem of passing 'dom := *'
to tr_GSUP_CL_REQ, which calls f_gen_tr_ies(), which in its turn
does not properly handle the '*' template kind:
'''
Dynamic test case error: Restriction `present' on template
of type @GSUP_Types.GSUP_CnDomain violated.
'''
The old code was basically equivalent of passing 'dom := ?',
i.e. expecting the OSMO_GSUP_CN_DOMAIN_IE to be present.
Work the problem around by having two alternatives:
* GSUP.receive(tr_GSUP_CL_REQ(dom := omit)
* GSUP.receive(tr_GSUP_CL_REQ(dom := ?)
This patch makes TC_hss_initiated_deregister_permanent_termination pass.
Change-Id: I26738c8c2a0a4b9066bfb619149cbdbaf3e3b5e1
Related: 51490419 ("library/gsup: improve GSUP_IE templates")
---
M epdg/EPDG_Tests.ttcn
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
osmith: Looks good to me, but someone else must approve
diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn
index d9300a6..b551b67 100644
--- a/epdg/EPDG_Tests.ttcn
+++ b/epdg/EPDG_Tests.ttcn
@@ -943,8 +943,10 @@
private altstep as_GSUP_rx_CL_REQ(template GSUP_CancelType ctype := omit) runs
on EPDG_ConnHdlr {
var GSUP_PDU rx_gsup;
- [] GSUP.receive(tr_GSUP_CL_REQ(g_pars.imsi, dom := *, ctype := ctype))
-> value rx_gsup {
- }
+ /* XXX: workaround for 'dom := *' causing a DTE:
+ * "Dynamic test case error: Restriction `present' on template of type
@GSUP_Types.GSUP_CnDomain violated." */
+ [] GSUP.receive(tr_GSUP_CL_REQ(g_pars.imsi, dom := omit, ctype :=
ctype)) -> value rx_gsup;
+ [] GSUP.receive(tr_GSUP_CL_REQ(g_pars.imsi, dom := ?, ctype := ctype))
-> value rx_gsup;
[] GSUP.receive(GSUP_PDU:?) -> value rx_gsup {
Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,
log2str("Unexpected GSUP msg rx: ", rx_gsup));
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38745?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I26738c8c2a0a4b9066bfb619149cbdbaf3e3b5e1
Gerrit-Change-Number: 38745
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
