Attention is currently required from: JPM, fixeria, laforge. dexter has posted comments on this change by JPM. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email )
Change subject: Fixing 3-digit MNC PlmnAdapter encoding & decoding, and related tests. ...................................................................... Patch Set 7: (1 comment) Patchset: PS6: Unfortunately this fix has a chicken-egg problem. The code looks correct to me. I even verified one of the testcases with pen and paper. Everything should be correct. However, the the build failure we see is in the pysim repository and I have fixed the testcases there now (see https://gerrit.osmocom.org/c/pysim/+/38941). The problem is that this of course only works with the fixed version of pyosmocom and the fixed version of pyosmocom only works with the fixed pysim. My suggestion would be to remove the pysim test from jenkins.sh as this creates some kind of a circular dependency. I can take care of this, if the reviewers are ok with that. -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I3811b227d629bd4e051a480c9622967e31f8a376 Gerrit-Change-Number: 38687 Gerrit-PatchSet: 7 Gerrit-Owner: JPM <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: JPM <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 25 Nov 2024 17:39:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
