pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmo-netif/+/38979?usp=email )
Change subject: stream_cli: Explicitly ignore return code of stream_cli_close
......................................................................
stream_cli: Explicitly ignore return code of stream_cli_close
Make coverity happy.
We don't really case about th return code of the stream_cli_close()
function in the code path, since the return value is only used
internally/privately in the object and there's no further access/use of
the object after calling it in osmo_stream_cli_close().
Take the chance to update syntax of one return code check to match more
similarly other return checks of the same function.
Related: Coverity CID#435092
Change-Id: Ia6c9e3ca3af08b386f017460b0a0210ed756a929
---
M src/stream_cli.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/79/38979/1
diff --git a/src/stream_cli.c b/src/stream_cli.c
index 43877d3..85ede60 100644
--- a/src/stream_cli.c
+++ b/src/stream_cli.c
@@ -219,7 +219,7 @@
* abstraction and close the socket */
void osmo_stream_cli_close(struct osmo_stream_cli *cli)
{
- stream_cli_close(cli);
+ (void)stream_cli_close(cli);
}
/*! Re-connect an Osmocom Stream Client.
@@ -967,7 +967,7 @@
return;
LOGSCLI(cli, LOGL_DEBUG, "destroy()\n");
- OSMO_ASSERT(!stream_cli_close(cli));
+ OSMO_ASSERT(stream_cli_close(cli) == false);
osmo_timer_del(&cli->timer);
msgb_queue_free(&cli->tx_queue);
cli->tx_queue_count = 0;
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38979?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ia6c9e3ca3af08b386f017460b0a0210ed756a929
Gerrit-Change-Number: 38979
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
