Attention is currently required from: fixeria, laforge.

lynxis lazus has posted comments on this change by lynxis lazus. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38397?usp=email )

Change subject: SGSN: BSSGP_ConnHdlr: GMM Service Request: handle PMM IDLE UE 
correct
......................................................................


Patch Set 5:

(3 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38397/comment/6913d70d_e13acf61?usp=email
 :
PS4, Line 9: explicit mention
> The spec. […]
Done


File sgsn/BSSGP_ConnHdlr.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38397/comment/5f1e4859_6aa2e444?usp=email
 :
PS4, Line 632: explicit
> Looks more like "implicit". The `tr_GMM_SERVICE_ACC` would be explicit (as 
> the name suggests).
Done


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38397/comment/5a30e4c1_97e64f2d?usp=email
 :
PS4, Line 640: } else {
> So depending on the UE state (IDLE or CONNECTED) we may receive: […]
Yes, you're right. Somehow I forgot here to invert the logic in the "Secuirty 
Command" branch to match it.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38397?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I29237997e414aea80f254247da54f909410a4b36
Gerrit-Change-Number: 38397
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Tue, 03 Dec 2024 15:43:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>
Comment-In-Reply-To: lynxis lazus <[email protected]>

Reply via email to