pespin has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-remsim/+/39021?usp=email )

Change subject: rspro_client: Make struct osmo_rspro_client private
......................................................................


Patch Set 2:

(1 comment)

File src/rspro_client_fsm.h:

https://gerrit.osmocom.org/c/osmo-remsim/+/39021/comment/e2d39a8b_1ea2be2d?usp=email
 :
PS2, Line 23: struct osmo_rspro_client {
AFAICT this object is actually not implemented anywhere, so I'd say we can 
totally drop it instead?

Somebody with osmo-remsimv knowledge please provide feedback.



--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39021?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I3bacae853101a79804553175ebd4482acb188597
Gerrit-Change-Number: 39021
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Tue, 03 Dec 2024 18:30:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to