Attention is currently required from: daniel, lynxis lazus, pespin.

osmith has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/39019?usp=email )

Change subject: Use gsup_client_mux from libosmo-gsup-client
......................................................................


Patch Set 2:

(1 comment)

File tests/msc_vlr/msc_vlr_tests.c:

https://gerrit.osmocom.org/c/osmo-msc/+/39019/comment/8c369cc3_3fcb8707?usp=email
 :
PS2, Line 843: /* override, requires '-Wl,--wrap=gsup_client_send' */
```suggestion
/* override, requires '-Wl,--wrap=gsup_client_mux_start 
-Wl,--wrap=gsup_client_mux_tx' */
```



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/39019?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I34d02ae219f3ec8daf47942c46f52b21eab21242
Gerrit-Change-Number: 39019
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: daniel <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Wed, 04 Dec 2024 09:38:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to