pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-hlr/+/39006?usp=email )
Change subject: gsup_client: Avoid double memset 0
......................................................................
gsup_client: Avoid double memset 0
Memory is already zeroed during talloc_zero, no need to reset it to
zero.
Change-Id: I66515fc893ffc64a36abedc01a75b57aed7e932d
---
M src/gsupclient/gsup_client.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
osmith: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
diff --git a/src/gsupclient/gsup_client.c b/src/gsupclient/gsup_client.c
index 1168c9d..3451677 100644
--- a/src/gsupclient/gsup_client.c
+++ b/src/gsupclient/gsup_client.c
@@ -307,7 +307,7 @@
OSMO_ASSERT(config->ipa_dev->unit_name);
- gsupc = talloc_zero(talloc_ctx, struct osmo_gsup_client);
+ gsupc = talloc(talloc_ctx, struct osmo_gsup_client);
OSMO_ASSERT(gsupc);
*gsupc = (struct osmo_gsup_client){
.unit_name = (const char *)config->ipa_dev->unit_name, /* API
backwards compat */
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/39006?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I66515fc893ffc64a36abedc01a75b57aed7e932d
Gerrit-Change-Number: 39006
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
