Attention is currently required from: fixeria, laforge, pespin.

lynxis lazus has posted comments on this change by lynxis lazus. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email )

Change subject: PCU_Tests_SNS: sns_del: check if removed NS-VC still transmits
......................................................................


Patch Set 2:

(1 comment)

File pcu/PCU_Tests_SNS.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011/comment/e4afa3e3_8866abf8?usp=email
 :
PS1, Line 327: integer idx := 0, integer idx_del := 1, float tout := 20.0
@pes...@sysmocom.de this is our test code. If there are unknown and unforseen 
side effect, we should know it.

> I'm sorry but I don't think it's good to start using parameters in testcase 
> with no real good reason or improvement. This may actually cause more 
> unforeseen problems than good things.

This sounds to me "we've never done it this way, never change a running 
system", which I don't see as valid argument.

> Well, then the point is: if parameters are not changed, why passing 
> parameters instead of declaring them as variables...

For me it makes the code more clearer/readable, defining essential variables as 
test case parameters and "promote" these variable to testcase parameters.
Further it would have make it easier to split it into a testcase and a function.

I'm not arguing here where to use testcase parameter in control() or not.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39011?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ied4367a519cf75291ff8766c9efebb0f8a12b11f
Gerrit-Change-Number: 39011
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lyn...@fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-CC: fixeria <vyanits...@sysmocom.de>
Gerrit-Attention: laforge <lafo...@osmocom.org>
Gerrit-Attention: fixeria <vyanits...@sysmocom.de>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Thu, 05 Dec 2024 13:17:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de>
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lyn...@fe80.eu>

Reply via email to