Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39035?usp=email )
Change subject: ipa: Add osmo_ipa_ka_fsm_inst APIs ...................................................................... Patch Set 4: (1 comment) File include/osmocom/netif/ipa.h: https://gerrit.osmocom.org/c/libosmo-netif/+/39035/comment/b312d658_cde3d09a?usp=email : PS3, Line 85: void *osmo_ipa_ka_fsm_get_data(const struct osmo_ipa_ka_fsm_inst *ka_fi); > I would normally hand the data directly to the call-back as an argument to > avoid the extra function […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39035?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5c36e06e0dc29ec4679b20ad6c426f051b659acd Gerrit-Change-Number: 39035 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Mon, 09 Dec 2024 10:03:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]>
