lynxis lazus has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38414?usp=email )

 (

7 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted 
one.
 )Change subject: SGSN: fix encoding of IMEISV in Auth and Ciphering Response
......................................................................

SGSN: fix encoding of IMEISV in Auth and Ciphering Response

According to 24.008 the IMEISV field is exact 11 bytes long and
must contain a IMEI + SV which is exact 16 digits long, not 15.

Change-Id: I79dd79840de58f450c1a05e704fd9bd831455716
---
M sgsn/BSSGP_ConnHdlr.ttcn
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  pespin: Looks good to me, but someone else must approve
  fixeria: Looks good to me, but someone else must approve
  daniel: Looks good to me, approved
  Jenkins Builder: Verified




diff --git a/sgsn/BSSGP_ConnHdlr.ttcn b/sgsn/BSSGP_ConnHdlr.ttcn
index 40cb6b6..1b2e5a0 100644
--- a/sgsn/BSSGP_ConnHdlr.ttcn
+++ b/sgsn/BSSGP_ConnHdlr.ttcn
@@ -354,9 +354,9 @@

        l3_mo := valueof(auth_ciph_resp);
        if 
(ispresent(l3_mt.msgs.gprs_mm.authenticationAndCipheringRequest.imeisvRequest) 
and
-           
l3_mt.msgs.gprs_mm.authenticationAndCipheringRequest.imeisvRequest.valueField 
== '001'B) {
+               
l3_mt.msgs.gprs_mm.authenticationAndCipheringRequest.imeisvRequest.valueField 
== '001'B) {
                l3_mo.msgs.gprs_mm.authenticationAndCipheringResponse.imeisv :=
-                                       valueof(ts_MI_IMEISV_TLV(g_pars.imei & 
'0'H));
+                                       valueof(ts_MI_IMEISV_TLV(g_pars.imei & 
'00'H));
        }
        f_send_l3(l3_mo, ran_index);
 }
@@ -448,7 +448,7 @@
                if 
(ispresent(l3_mt.msgs.gprs_mm.authenticationAndCipheringRequest.imeisvRequest) 
and
                    
l3_mt.msgs.gprs_mm.authenticationAndCipheringRequest.imeisvRequest.valueField 
== '001'B) {
                        
l3_mo.msgs.gprs_mm.authenticationAndCipheringResponse.imeisv :=
-                                               
valueof(ts_MI_IMEISV_TLV(g_pars.imei & '0'H));
+                                               
valueof(ts_MI_IMEISV_TLV(g_pars.imei & '00'H));
                }
                f_send_l3(l3_mo, ran_index);


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38414?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I79dd79840de58f450c1a05e704fd9bd831455716
Gerrit-Change-Number: 38414
Gerrit-PatchSet: 11
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>

Reply via email to