pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-remsim/+/39131?usp=email )
Change subject: rspro_client_fsm: Fix missing return
......................................................................
rspro_client_fsm: Fix missing return
Recent commit added error return code paths through goto labels at the
end, but forgot to add a return statement to avoid running onto them
during normal code flow.
Fixes: 8cfe1d808a57a0a877e934e0435651a6b792db8d
Change-Id: I813432d42135b5f3f086ad93bd63bfa39f4becbc
---
M src/rspro_client_fsm.c
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c
index 29e0287..6a48ce4 100644
--- a/src/rspro_client_fsm.c
+++ b/src/rspro_client_fsm.c
@@ -493,6 +493,7 @@
/* FIXME: retry? Timer? Abort? */
goto err_free_ka_fi;
}
+ return;
err_free_ka_fi:
osmo_ipa_ka_fsm_free(srvc->ka_fi);
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39131?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I813432d42135b5f3f086ad93bd63bfa39f4becbc
Gerrit-Change-Number: 39131
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
