Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/25559?usp=email )
Change subject: ns2: trigger a reset in case of receiving a NS STATUS with incompatible protocol state ...................................................................... Patch Set 3: (1 comment) File src/gb/gprs_ns2_vc_fsm.c: https://gerrit.osmocom.org/c/libosmocore/+/25559/comment/936ad6af_2616dbcb?usp=email : PS3, Line 748: if (fi->state != GPRS_NS2_ST_RESET && fi->state != GPRS_NS2_ST_UNCONFIGURED) { > shouldn't we also move to some "unconfigured" state ourselves to be in sync > with the peer after rese […] I'll mark it as wip again. It depends on the NS mode: - for SNS we might want to do handle it in a different way, because this shouldn't happen in SNS. Maybe try to remove it? Unsure atm. Because it would mean, somehow we managed to get out of sync. - for IPA style, go to reset - for NS static, go into recovering. Also it would be great to analyse the underlying message, if available. Because if we received a NS Alive as failure, we can be sure, we have to go to reset, otherwise a BLOCKED NS-VC might be detectable by this. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25559?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I912315f816bd0597d4646627dbfdd270fbae2509 Gerrit-Change-Number: 25559 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Wed, 11 Dec 2024 20:14:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
