Attention is currently required from: lynxis lazus.

laforge has posted comments on this change by lynxis lazus. ( 
https://gerrit.osmocom.org/c/osmo-ggsn/+/38930?usp=email )

Change subject: gtp_new(): use talloc instead of calloc/free
......................................................................


Patch Set 5:

(1 comment)

File gtp/gsn.c:

https://gerrit.osmocom.org/c/osmo-ggsn/+/38930/comment/aaa68ec8_1c077ba5?usp=email
 :
PS3, Line 592: tall_gsn_ctx
> slight naming inconsistency: The name of the context is "libgtp" (which is a 
> specific library, likel […]
not sure if you missed this content as there were two new versions without 
addressing it in code or as a comment here?



--
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38930?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I7c4a29c4bb1ef3c7bf506e59e99b3a804cabe34b
Gerrit-Change-Number: 38930
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Sun, 15 Dec 2024 12:15:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>

Reply via email to