Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39173?usp=email )
Change subject: pcap-client: Move stats to its own file ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File include/osmo-pcap/osmo_pcap_client.h: https://gerrit.osmocom.org/c/osmo-pcap/+/39173/comment/9990fd50_89708e56?usp=email : PS2, Line 34: struct rate_ctr_group; can be removed File src/osmo_client_stats.c: https://gerrit.osmocom.org/c/osmo-pcap/+/39173/comment/d410094b_9cd65851?usp=email : PS2, Line 29: #include <osmocom/vty/logging.h> : #include <osmocom/vty/telnet_interface.h> : #include <osmocom/vty/stats.h> : #i There's no VTY stuff in this file, so drop these? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39173?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I4b5ecdd6f9b0c646dd03ca3bc7fa24624fb9fcbc Gerrit-Change-Number: 39173 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Tue, 24 Dec 2024 13:49:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
