pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-pcap/+/39192?usp=email )
Change subject: pcap-server: remove unneeded check for null base_path
......................................................................
pcap-server: remove unneeded check for null base_path
It cannot be ever NULL. It is set to a non-null path during alloc(), and
it can only be replaced with another string through VTY.
Change-Id: I2f503f6f9af35d6ae6fbd03e85cade4f0eb93df2
---
M src/osmo_server_vty.c
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
pespin: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/osmo_server_vty.c b/src/osmo_server_vty.c
index 6a44da6..c3014c9 100644
--- a/src/osmo_server_vty.c
+++ b/src/osmo_server_vty.c
@@ -96,8 +96,7 @@
vty_out(vty, "server%s", VTY_NEWLINE);
- if (pcap_server->base_path)
- vty_out(vty, " base-path %s%s", pcap_server->base_path,
VTY_NEWLINE);
+ vty_out(vty, " base-path %s%s", pcap_server->base_path, VTY_NEWLINE);
vty_out(vty, " file-permission-mask 0%o%s",
pcap_server->permission_mask, VTY_NEWLINE);
if (pcap_server->addr)
vty_out(vty, " server ip %s%s", pcap_server->addr, VTY_NEWLINE);
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39192?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: I2f503f6f9af35d6ae6fbd03e85cade4f0eb93df2
Gerrit-Change-Number: 39192
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: laforge <[email protected]>
