Attention is currently required from: laforge.

dexter has posted comments on this change by dexter. ( 
https://gerrit.osmocom.org/c/pysim/+/39225?usp=email )

Change subject: global_platform: fix usage of the Key Version Number (kvn)
......................................................................


Patch Set 3:

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/pysim/+/39225/comment/0b0fac03_f44c0dd1?usp=email :
PS2, Line 19: sjs1
> SJS is upper case in the product name.
Done


File pySim/global_platform/scp.py:

https://gerrit.osmocom.org/c/pysim/+/39225/comment/0e3eee03_f247ef3c?usp=email :
PS2, Line 230:     kvn_ranges = [[0x00, 0x00], [0x01, 0x01], [0x20, 0x2f], 
[0x70, 0x70]]
> AFACT, the spec says [somewhere] that SCP02 uses 2x and SCP03 uses 3x - we 
> just have some products t […]
I have tried to find some more information about those ranges, but I couldn't 
find any information about this.

However, in GPC_SPE_034, section 7.5.1 there I find the following:

There is no restriction and no pre-defined order in assigning Key Version 
Numbers and Key Identifiers to keys, including non-sequential Key Version 
Numbers and Key Identifiers within the same Security Domain.

I would keep the range checking and turn the exception into a warning. This 
would allow us to use any KVN with pySim-shell.



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/39225?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I42be2438c7f199b238f2ec7a9434cec5393210a7
Gerrit-Change-Number: 39225
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Mon, 06 Jan 2025 15:58:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: dexter <[email protected]>

Reply via email to