Attention is currently required from: pespin.

lynxis lazus has posted comments on this change by lynxis lazus. ( 
https://gerrit.osmocom.org/c/osmo-iuh/+/38947?usp=email )

Change subject: iu_client: add a new event NEW_LAC_RAC
......................................................................


Patch Set 3:

(1 comment)

File include/osmocom/ranap/iu_client.h:

https://gerrit.osmocom.org/c/osmo-iuh/+/38947/comment/3b79a558_f34f8713?usp=email
 :
PS3, Line 50:   RANAP_IU_EVENT_NEW_LAC_RAC, /* Either a new LAC/RAC has been 
detected */
> Have a look at struct gsm0808_cell_id. Not saying you must use it, but worth 
> a thought. […]
Btw. iu_client is also somehow deprecated. Because it abstractions are not well 
designed. For this reason neels already rewritten the MSC code to not use 
iu_client. But currently I don't want to replace it. Too much changing parts 
already.
Yes maybe we can use gsm0808_cell_id_u. But currently I would rather go with 
this approach. It is not the best approach (rewrite ;) but having at least some 
information would be sufficient IMHO.



--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38947?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I8b1b8c58bf72b00e2705ca87a89a91481bac3470
Gerrit-Change-Number: 38947
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Tue, 07 Jan 2025 16:45:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Comment-In-Reply-To: lynxis lazus <[email protected]>

Reply via email to