Attention is currently required from: daniel, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39265?usp=email )
Change subject: client: Support generation of pcapng file format ...................................................................... Patch Set 8: (3 comments) File doc/manuals/chapters/client.adoc: https://gerrit.osmocom.org/c/osmo-pcap/+/39265/comment/01f3e45b_9d5c6dc3?usp=email : PS8, Line 59: reate > create Done File include/osmo-pcap/osmo_pcap_file.h: https://gerrit.osmocom.org/c/osmo-pcap/+/39265/comment/0df37a3e_3053cca0?usp=email : PS8, Line 87: /* uint32_t block_total_length */ > looks like a leftover, because block_total_length is already in line 85 Nope, it's fine, the field is duplicated at the end of block_body so that the file can be navigated backwards. See pcapng spec 😊 File src/osmo_client_network.c: https://gerrit.osmocom.org/c/osmo-pcap/+/39265/comment/da2123ef_81082df2?usp=email : PS8, Line 389: . > (remove the dot?) Done -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39265?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I3c80518a1e53a1f77e1aca8dfa83f683f9516ad6 Gerrit-Change-Number: 39265 Gerrit-PatchSet: 8 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Comment-Date: Mon, 13 Jan 2025 16:14:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <[email protected]>
