Attention is currently required from: daniel, laforge, osmith.
Hello Jenkins Builder, daniel, laforge, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-pcap/+/39287?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Code-Review+1 by osmith, Verified+1 by Jenkins Builder
Change subject: server: Support storing of pcapng format
......................................................................
server: Support storing of pcapng format
Improve existing logic doing validation on payload data and generalize
the file_hdr field to account for the possibily of receiving recordings
in pcapng format.
This requires, during LINK_HDR when file header is received, discerning
whether the recording is being done in pcap vs pcapng, (and in pcapng
figuring out the endianness of the file) and then applying validation
based on that knowledge.
With that knowledge, osmo-pcap-server can now store the pcap(ng) file
using the proper suffix for the file.
Related: SYS#5822
Change-Id: I275d28ab418a1514fa9c5c7c20f3d831cc6af8bb
---
M include/osmo-pcap/osmo_pcap_file.h
M include/osmo-pcap/osmo_pcap_server.h
M src/Makefile.am
M src/osmo_pcap_file.c
M src/osmo_server_network.c
M tests/rotate_localtime/Makefile.am
6 files changed, 333 insertions(+), 46 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/87/39287/6
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39287?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: I275d28ab418a1514fa9c5c7c20f3d831cc6af8bb
Gerrit-Change-Number: 39287
Gerrit-PatchSet: 6
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: daniel <[email protected]>
