Attention is currently required from: osmith. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39234?usp=email )
Change subject: RFC: add support to create a shallow copy ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Thanks for making this! […] The motivation for this is: "my source tree shouldn't be touched by osmo-dev at all". Also security wise I don't like it can modify my tree. You need a autoreconf -fi/compile anyway, because the docker and my system might (and are) complete different. This also is a problem, because autoconf have a problem, if I build in-tree. Changing to cmake seems to be much bigger work than this. Maybe "shallow" is the wrong word. In OpenWrt this feature is call git-src tree override, which allows ignoring the source.tar.gz of a package. Yes, it doesn't track uncommitted changes, but IMHO, this is ok, as long it is clear. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39234?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0f1ac8852218f158ece14c176f05574f60d9d1f7 Gerrit-Change-Number: 39234 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Comment-Date: Tue, 14 Jan 2025 15:13:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <[email protected]> Comment-In-Reply-To: lynxis lazus <[email protected]>
