osmith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/39342?usp=email )


Change subject: ansible: coverity: improve file not found error
......................................................................

ansible: coverity: improve file not found error

Abort early when the coverity tarball was not found and tell the user
where they can download it, and where exactly the file needs to be.

Change-Id: Iddf629abd5c5a87afc238fbf6927cda9aa6f49b2
---
M ansible/roles/install-coverity/tasks/main.yml
1 file changed, 5 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/42/39342/1

diff --git a/ansible/roles/install-coverity/tasks/main.yml 
b/ansible/roles/install-coverity/tasks/main.yml
index 0d43a27..7dc3043 100644
--- a/ansible/roles/install-coverity/tasks/main.yml
+++ b/ansible/roles/install-coverity/tasks/main.yml
@@ -23,24 +23,21 @@
       register: coverity_copy
       ignore_errors: yes

+    - name: coverity download hint
+      ansible.builtin.fail:
+        msg: "Login and download {{ coverity_installer_file }} from 
https://scan.coverity.com/download (Linux64) and put it into 
osmo-ci/ansible/files."
+      when: coverity_copy.failed == True
+
     - name: create /opt/coverity/{{ coverity_version }}/
       file:
         path: /opt/coverity/{{ coverity_version }}/
         state: directory
-      when: coverity_copy.failed == False

     - name: unpack coverity
       unarchive:
         src: "/tmp/{{ coverity_installer_file }}"
         dest: /opt/coverity/{{ coverity_version }}
         remote_src: yes
-      when: coverity_copy.failed == False

     - name: create link /opt/coverity/current
       shell: rm -vf /opt/coverity/current && ln -svf /opt/coverity/{{ 
coverity_version }}/* /opt/coverity/current
-      when: coverity_copy.failed == False
-
-    - name: "Please download {{ coverity_installer_file }} to your ansible 
directory to allow ansible to install coverity"
-      debug:
-        msg: "Ansible can not find {{ coverity_installer_file }}"
-      when: coverity_copy.failed

--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39342?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Iddf629abd5c5a87afc238fbf6927cda9aa6f49b2
Gerrit-Change-Number: 39342
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <[email protected]>

Reply via email to