Attention is currently required from: laforge.

pespin has posted comments on this change by fixeria. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/39188?usp=email )

Change subject: gsm_rlcmac: fix EGPRS BEP Link Quality Measurements Type 2
......................................................................


Patch Set 3:

(1 comment)

File tests/rlcmac/RLCMACTest.err:

https://gerrit.osmocom.org/c/osmo-pcu/+/39188/comment/f8aa4b28_fe323844?usp=email
 :
PS2, Line 42: DCSN1 INFO csnStreamDecoder (type: Pkt Resource Req (5)): 
PayloadType = 1 | spare = 0 | R = 0 | MESSAGE_TYPE = 5 | Exist_ACCESS_TYPE = 1 
| ACCESS_TYPE = 3 |  : ID | Choice PacketResourceRequestID = 1 | u.TLLI = 
0x96cb3568 | : End ID | Exist_MS_Radio_Access_capability2 = 1 |  : 
MS_Radio_Access_capability2 | MS_RA_capability_value { | Choice 
MS_RA_capability_value_Choice = 7 | u.Content length = 50 | offset = 1 | 
RF_Power_Capability = 4 | Exist_A5_bits = 1 | A5_bits = 80 | ES_IND = 1 | PS = 
1 | VGCS = 0 | VBS = 0 | Exist_Multislot_capability = 1 |  : 
Multislot_capability | Exist_HSCSD_multislot_class = 0 | 
Exist_GPRS_multislot_class = 1 | GPRS_multislot_class = 11 | 
GPRS_Extended_Dynamic_Allocation_Capability = 1 | Exist_SM = 1 | SMS_VALUE = 2 
| SM_VALUE = 2 | Exist_ECSD_multislot_class = 0 | Exist_EGPRS_multislot_class = 
1 | EGPRS_multislot_class = 11 | EGPRS_Extended_Dynamic_Allocation_Capability = 
1 | Exist_DTM_GPRS_multislot_class = 0 | : End Multislot_capability | 
Exist_Eight_PSK_Power_Capability = 1 | Eight_PSK_Power_Capability = 2 | 
COMPACT_Interference_Measurement_Capability = 0 | Revision_Level_Indicator = 1 
| UMTS_FDD_Radio_Access_Technology_Capability = 0 | 
UMTS_384_TDD_Radio_Access_Technology_Capability = 0 | 
CDMA2000_Radio_Access_Technology_Capability = 0 | 
UMTS_128_TDD_Radio_Access_Technology_Capability = NULL | 
GERAN_Feature_Package_1 = NULL | Modulation_based_multislot_class_support = 
NULL | GMSK_MultislotPowerProfile = NULL | EightPSK_MultislotProfile = NULL | 
MultipleTBF_Capability = NULL | DownlinkAdvancedReceiverPerformance = NULL | 
ExtendedRLC_MAC_ControlMessageSegmentionsCapability = NULL | 
DTM_EnhancementsCapability = NULL | PS_HandoverCapability = NULL | 
DTM_Handover_Capability = NULL | FlexibleTimeslotAssignment = NULL | 
GAN_PS_HandoverCapability = NULL | RLC_Non_persistentMode = NULL | 
ReducedLatencyCapability = NULL | UplinkEGPRS2 = NULL | DownlinkEGPRS2 = NULL | 
EUTRA_FDD_Support = NULL | EUTRA_TDD_Support = NULL | 
GERAN_To_EUTRAN_supportInGERAN_PTM = NULL | PriorityBasedReselectionSupport = 
NULL | MS_RA_capability_value } | : End MS_Radio_Access_capability2 |  : 
Channel_Request_Description | PEAK_THROUGHPUT_CLASS = 9 | RADIO_PRIORITY = 0 | 
RLC_MODE = 0 | LLC_PDU_TYPE = 1 | RLC_OCTET_COUNT = 39 | : End 
Channel_Request_Description | Exist_CHANGE_MARK = 0 | C_VALUE = 19 | 
Exist_SIGN_VAR = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | 
I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | 
I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | 
Exist_AdditionsR99 = 1 |  : AdditionsR99 | 
Exist_EGPRS_BEP_LinkQualityMeasurements = 0 | 
Exist_EGPRS_TimeslotLinkQualityMeasurements = 0 | Exist_PFI = 0 | 
MS_RAC_AdditionalInformationAvailable = 0 | RetransmissionOfPRR = 0 | 
Exist_AdditionsR5 = 1 |  : AdditionsR5 | Exist_Iu_Mode_ChRequestDesk = 0 | 
Exist_HFN_LSB = 0 | Exist_AdditionsR6 = 1 |  : AdditionsR6 | 
Exist_Ext_Channel_Request_desc = 0 | Exist_AdditionsR7 = 1 |  : AdditionsR7 | 
EARLY_TBF_ESTABLISHMENT = 0 | Exist_EGPRS_BEP_LinkQualityMeasurements_type2 = 1 
|  : EGPRS_BEP_LinkQualityMeasurements_type2 | Exist_GMSK_MEAN_BEP = 1 | 
GMSK_MEAN_BEP = 5 | GMSK_CV_BEP = 3 | Exist_8PSK_MEAN_BEP = 0 | 
Exist_QPSK_MEAN_BEP = 0 | Exist_16QAM_NSR_MEAN_BEP = 1 | p16QAM_NSR_MEAN_BEP = 
11 | DCSN1 ERROR csnStreamDecoder: error NEED_MORE BITS TO UNPACK (-5) at 
p16QAM_NSR_CV_BEP (idx 184): End EGPRS_BEP_LinkQualityMeasurements_type2 | : 
End AdditionsR7 | : End AdditionsR6 | : End AdditionsR5 | : End AdditionsR99 |
> As I said, it's an unrelated problem. Early versions of 3GPP TS 44. […]
Maybe you want to copy this rationale at the end of the commit message after 
"unrelated problem:" otherwise the reader has not clue what the unrealted 
problem is about.



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/39188?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I061ac16df5e6413266de08884f791f0264791192
Gerrit-Change-Number: 39188
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Wed, 15 Jan 2025 16:55:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to