Attention is currently required from: pespin.

laforge has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-pcap/+/39343?usp=email )

Change subject: server: Use osmo_stream_srv for non-tls read tcp sock
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/osmo-pcap/+/39343/comment/6e672c29_9526261a?usp=email
 :
PS2, Line 9: TLS handling adds a lot of complexity, so TLS sockets are still 
read
           : through the previous code paths, and conversion to osmo_stream_srv 
is
           : left as a future improvement.
one might even argue that osmo_stream itself should integrate the TLS support 
at some point, so that all of those details are kept out of the applications 
just wanting to use a TLS socket.



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39343?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: I537620fcad6c8e65206a41a1c21bd4b6453fbed4
Gerrit-Change-Number: 39343
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Thu, 16 Jan 2025 11:26:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to