Attention is currently required from: daniel, laforge, neels.
pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/libosmo-netif/+/39316?usp=email )
Change subject: stream: Introduce osmo_stream_{cli,srv}_set_segmentation_cb2
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> I am wondering if there's another alternative that we can do this without
> introducing the clumsy *2( […]
@[email protected] you mean keeping the segmentation_cb(1) and adding
"cli/srv" pointer inside msgb->dst or cb[]?
I'd prefer having a proper param as in cb2, because:
* osmo_io anyway already has such a cb
* we are already using msg->cb[] to store some information in sctp sockets iirc.
* It becomes easier for users to understand quickly how to implement stuff when
looking at the API instead of having to read docuemntaion details regarding the
object being available in that field of msg.
IMHO the initial segmentation_cb without a data param both in osmo_io and
osmo_stream was a bad choice, and I really think it makes sense to deprecate it
and get rid of it at some point.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39316?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I6e8dd6ece13397074075f05a1a0a8dbdd80d8848
Gerrit-Change-Number: 39316
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: daniel <[email protected]>
Gerrit-Comment-Date: Thu, 16 Jan 2025 14:59:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
