Attention is currently required from: pespin.

osmith has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-pcap/+/39367?usp=email )

Change subject: server: Implement non-blocking write to pcap file with osmo_io
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

File src/osmo_pcap_wr_file.c:

https://gerrit.osmocom.org/c/osmo-pcap/+/39367/comment/7e7a7854_166df88a?usp=email
 :
PS2, Line 47: werf
wrf?


File src/osmo_server_core.c:

https://gerrit.osmocom.org/c/osmo-pcap/+/39367/comment/d2a88811_d106c7f0?usp=email
 :
PS2, Line 262: lossing
losing



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39367?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: I098a9455a2a4cc626444e6fc13aa88c4cc9694f0
Gerrit-Change-Number: 39367
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Mon, 20 Jan 2025 08:26:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to