laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39372?usp=email )

Change subject: gbproxy: Don't log the payload size for every DL/UL-UNITDATA
......................................................................

gbproxy: Don't log the payload size for every DL/UL-UNITDATA

This just wastes memory. We can check the pcaps if a test does fail.

Change-Id: I862d67a48f1d694262cf39a1e939033bde0c6eab
Related: OS#6704
---
M gbproxy/GBProxy_Tests.ttcn
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  osmith: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified
  laforge: Looks good to me, approved




diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn
index 7a6572a..7f70f96 100644
--- a/gbproxy/GBProxy_Tests.ttcn
+++ b/gbproxy/GBProxy_Tests.ttcn
@@ -1231,7 +1231,6 @@
                /* we cannot use pdu_tx as there are some subtle differences in 
the length field :/ */
                var template (present) PDU_BSSGP pdu_rx := 
tr_BSSGP_UL_UD(g_pars.tlli, bvcc.cell_id, payload);

-               log("UL-UNITDATA(payload_size=", i);
                f_pcu2sgsn(pdu_tx, pdu_rx);
        }
        setverdict(pass);
@@ -1261,7 +1260,6 @@
                /* we cannot use pdu_tx as there are some subtle differences in 
the length field :/ */
                var template (present) PDU_BSSGP pdu_rx := 
tr_BSSGP_UL_UD(g_pars.tlli, bvcc.cell_id, payload);

-               log("UL-UNITDATA(payload_size=", i);
                f_pcu2sgsn(pdu_tx, pdu_rx);
        }
        setverdict(pass);
@@ -1319,7 +1317,6 @@
                var template (present) PDU_BSSGP pdu_rx :=
                        tr_BSSGP_DL_UD(g_pars.tlli, payload, 
tr_BSSGP_IMSI(g_pars.imsi));

-               log("DL-UNITDATA(payload_size=", i, ")");
                f_sgsn2pcu(pdu_tx, pdu_rx);
        }
        setverdict(pass);

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39372?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I862d67a48f1d694262cf39a1e939033bde0c6eab
Gerrit-Change-Number: 39372
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>

Reply via email to