Attention is currently required from: neels. fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39362?usp=email )
Change subject: hnbgw_rx_hnb_register_req(): guard against asn.1 parsing errors ...................................................................... Patch Set 2: (1 comment) File src/osmo-hnbgw/hnbgw_hnbap.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/39362/comment/afb5d012_843b807f?usp=email : PS2, Line 494: make sure that actual values ended up in the asn1 octet strings Are these fields marked as `MANDATORY` in the respective ASN.1 definition? If so, then I would expect `hnbap_decode_hnbregisterrequesties()` to fail (return negative) if at least one `MANDATORY` field/IE is somehow missing. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39362?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I555f11cadc23ea231821bd48f7cd62953b022e9e Gerrit-Change-Number: 39362 Gerrit-PatchSet: 2 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Comment-Date: Mon, 20 Jan 2025 13:00:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
