Attention is currently required from: fixeria, laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39199?usp=email )
Change subject: global_platform: add new command "install_cap" ...................................................................... Patch Set 8: (6 comments) File docs/cap-tutorial.rst: https://gerrit.osmocom.org/c/pysim/+/39199/comment/eedb4d95_b3c5cd35?usp=email : PS7, Line 5: support > "do support ... […] Done https://gerrit.osmocom.org/c/pysim/+/39199/comment/79a263ed_59bfaa56?usp=email : PS7, Line 54: "maximum_length_of_data_field_in_command_message": 255 > shouldn't there be an additional indention level? Done File pySim/global_platform/__init__.py: https://gerrit.osmocom.org/c/pysim/+/39199/comment/ab475327_feb0ba5d?usp=email : PS7, Line 868: install Parameters (GPC_SPE_034, section 11.5.2.3.7, table 11-49 > looks like copy paste. […] Done https://gerrit.osmocom.org/c/pysim/+/39199/comment/2ce5cdc9_a41929c0?usp=email : PS7, Line 865: install_cap_parser.add_argument('--install-parameters', type=is_hexstr, default='', : help='install Parameters (GPC_SPE_034, section 11.5.2.3.7, table 11-49)') : install_cap_parser.add_argument('--install-parameters-volatile-memory-quota', type=int, default=None, : help='install Parameters (GPC_SPE_034, section 11.5.2.3.7, table 11-49)') : install_cap_parser.add_argument('--install-parameters-non-volatile-memory-quota', type=int, default=None, : help='Install Parameters (GPC_SPE_034, section 11.5.2.3.7, table 11-49)') : install_cap_parser.add_argument('--install-parameters-stk', type=is_hexstr, default=None, : > Like in previous patch, define them as mutually exclusive params? […] Done File pySim/global_platform/install_param.py: https://gerrit.osmocom.org/c/pysim/+/39199/comment/4606bebd_40939138?usp=email : PS7, Line 20: from construct import Optional as COptional : fr > none of these used? Done File tests/unittests/test_globalplatform.py: https://gerrit.osmocom.org/c/pysim/+/39199/comment/ff714f48_d773691f?usp=email : PS7, Line 24: * > you only need `gen_install_parameters()`, so import it alone? […] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6cbd37f0fad5579b20e83c27349bd5acc129e6d0 Gerrit-Change-Number: 39199 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Tue, 21 Jan 2025 15:14:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]>
