Attention is currently required from: fixeria, laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37454?usp=email )
Change subject: global_platform: LOAD and INSTALL [for load] support ...................................................................... Patch Set 8: (6 comments) File pySim/global_platform/__init__.py: https://gerrit.osmocom.org/c/pysim/+/37454/comment/d0b86d47_d126d2ff?usp=email : PS7, Line 20: import io > unused import? […] I think you overlooked it. It is used in do_load https://gerrit.osmocom.org/c/pysim/+/37454/comment/92fe6e77_6cbea201?usp=email : PS7, Line 772: Prefixed(Int8ub, GreedyBytes > This is basically LV structure. […] I have tried out what happens when I use LV, but it does not work. LV is indeed different. We use the /HexAdapter(Prefixed(Int8ub, GreedyBytes) in various other places too. I would suggest to keep it like it is. https://gerrit.osmocom.org/c/pysim/+/37454/comment/b1b72fc3_f8ebe365?usp=email : PS7, Line 824: ('--from-hex > why not using `type=is_hexstr` here? Done https://gerrit.osmocom.org/c/pysim/+/37454/comment/748236aa_590511e3?usp=email : PS7, Line 824: load_parser.add_argument('--from-hex', help='load from hex string') : load_parser.add_argument('--from-file', help='load from binary file') : > If these params are mutually-exclusive (only one of these must be supplied), > please create a group u […] Done https://gerrit.osmocom.org/c/pysim/+/37454/comment/bd7de28c_9c538c20?usp=email : PS7, Line 833: > formatting Interesting that I got no errors, python3 is normally very picky about this. https://gerrit.osmocom.org/c/pysim/+/37454/comment/9fea01be_001e428d?usp=email : PS7, Line 835: with open(opts.from_file, 'rb') as f: > BTW, argparse does have: https://docs.python.org/3/library/argparse. […] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37454?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I924aaeecbb3a72bdb65eefbff6135e4e9570579e Gerrit-Change-Number: 37454 Gerrit-PatchSet: 8 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: dexter <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Tue, 21 Jan 2025 15:14:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]>
