Attention is currently required from: laforge.
pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-remsim/+/39385?usp=email )
Change subject: Use use new osmo_stream_{cli,srv}_set_segmentation_cb2
......................................................................
Patch Set 1:
(1 comment)
File src/rspro_client_fsm.c:
https://gerrit.osmocom.org/c/osmo-remsim/+/39385/comment/13cf492b_9b92e265?usp=email
:
PS1, Line 142: static int srvc_ipa_segmentation_cb2(struct osmo_stream_cli
*cli, struct msgb *msg)
: {
: return osmo_ipa_segmentation_cb(msg);
: }
:
> it's not really elegant that this API improvement now requires us to
> sprkinkle boilerplate code like […]
@[email protected] While it involves a bit more code I think it's totally
fine.
If you don't like the proposed approach, the alternative approach is to
un-deprecate segmentation_cb (allowing any of segmentation_cb and
segmentation_cb2 to be used) and then dropping this patchset (keep using
segmentation_cb here).
Let me know which one you prefer and I'll do so.
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39385?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I02c55179a144e3bbd1f760f5429e16c6e327111e
Gerrit-Change-Number: 39385
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Thu, 23 Jan 2025 13:50:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
