Attention is currently required from: daniel, fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39396?usp=email )
Change subject: Pass ownership of Tx xua_msg down the stack [1/2] ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: The patch looks good to me. Since these are just internal changes in libosmo-sigtran (from what I can tell no Osmocom program/library is using the modified functions directly outside of libosmo-sigtran, even the non-static ones) and Pau said that all tests pass with this, it should be fine to merge this IMHO if Harald is fine with the architectural change. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39396?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I49e718e624da08510a9c3d28bdb360c59f9a65d3 Gerrit-Change-Number: 39396 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Comment-Date: Fri, 24 Jan 2025 11:00:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
