Attention is currently required from: osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39397?usp=email )
Change subject: Pass ownership of Rx xua_msg up the stack [2/2] ...................................................................... Patch Set 2: (6 comments) File src/ipa.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/39397/comment/5c3ed8de_79da6bc0?usp=email : PS2, Line 304: ownsership > ```suggestion […] Done File src/m3ua.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/39397/comment/75c4fd44_9fbb006d?usp=email : PS2, Line 627: ownsership > ```suggestion […] Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/39397/comment/face901f_936e4ddd?usp=email : PS2, Line 784: goto out; > missing `xua_msg_free(xua);` since it doesn't go through any `m3ua_rx_*`? Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/39397/comment/ca94c065_7591f592?usp=email : PS2, Line 815: err = m3ua_gen_error_msg(M3UA_ERR_UNSUPP_MSG_CLASS, msg); > missing `xua_msg_free(xua);` since it doesn't go through any `m3ua_rx_*`? Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/39397/comment/cc0dcb96_2711faa2?usp=email : PS2, Line 1015: return M3UA_ERR_UNSUPP_MSG_TYPE; > ```suggestion […] Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/39397/comment/ebc82a1d_e61f3d68?usp=email : PS2, Line 1019: return M3UA_ERR_UNSUPP_MSG_TYPE; > ```suggestion […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39397?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Icf3b4dda550637f722a9fe56d0313f49c8a2964e Gerrit-Change-Number: 39397 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Comment-Date: Fri, 24 Jan 2025 13:43:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <[email protected]>
