Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39415?usp=email )
Change subject: Add GSMTAP logging handler ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: it looks good from a quick glance, however the build fails: ``` ===> Compiling src/logger_gsmtap_h.erl failed src/logger_gsmtap_h.erl:61:17: syntax error before: 0.0 src/logger_gsmtap_h.erl:84:2: Warning: behaviour logger_handler undefined ``` -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39415?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Iea884e2ca146b852c64bd9f135d8c71f4c925f09 Gerrit-Change-Number: 39415 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Mon, 27 Jan 2025 07:46:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
