Attention is currently required from: pespin.

lynxis lazus has posted comments on this change by lynxis lazus. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256?usp=email )

Change subject: SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_changed
......................................................................


Patch Set 3:

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/9bb93f71_9bfff790?usp=email
 :
PS3, Line 12: message, the old GMM Attach should be discard silently and a new
> dicarded?
Done


File sgsn/SGSN_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/d104dca4_fde9b82b?usp=email
 :
PS3, Line 2215:                         /* FIXME: Extract P-TMSI, if any. Only 
send Complete if necessary */
> what about this?
Something to improve, but the test case is already testing the important stuff.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia721d3c29bf09014b197670ae02d1cd1901750bc
Gerrit-Change-Number: 39256
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Mon, 27 Jan 2025 22:44:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to